diff options
| author | Jessica Clarke <jrtc27@jrtc27.com> | 2021-07-11 03:28:19 +0100 |
|---|---|---|
| committer | Anup Patel <anup@brainfault.org> | 2021-07-11 17:20:42 +0530 |
| commit | 7f1be8a624aca4805020588894d96c3617860c89 (patch) | |
| tree | e42f6c8f93c6b315ce0e395e9669d73883a21227 | |
| parent | a76ac4449bf2b67b899ebdb5085834e94987b690 (diff) | |
fw_base: Don't mark fw_platform_init as both global and weak
These are mutually exclusive. GNU as and LLVM both let later binding
directives override earlier ones so this works as intended, but LLVM 12
turned this into a warning as there's no good reason to do such a thing
and could be a potential bug. Thus, remove the redundant and incorrect
.globl directive for fw_platform_init.
Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Anup Patel <anup.patel@wdc.com>
| -rw-r--r-- | firmware/fw_base.S | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/firmware/fw_base.S b/firmware/fw_base.S index 8e40562..a1213e3 100644 --- a/firmware/fw_base.S +++ b/firmware/fw_base.S @@ -558,7 +558,6 @@ _start_hang: .section .entry, "ax", %progbits .align 3 - .globl fw_platform_init .weak fw_platform_init fw_platform_init: add a0, a1, zero |