From 1718b1642ee8c31eb2c49d78b5834e06f3324394 Mon Sep 17 00:00:00 2001 From: Dong Du <Dd_nirvana@sjtu.edu.cn> Date: Fri, 27 Aug 2021 22:46:28 +0800 Subject: lib: sbi: Checking fifo validness in sbi_fifo_is_empty and is_full As other exported fifo functions, we should check whether the fifo is valid in sbi_fifo_is_empty and sbi_fifo_is_full. To this end, this patch changes the retval from bool to int, and the two functions will return SBI_EINVAL in the case the fifo is invalid. Signed-off-by: Dong Du <Dd_nirvana@sjtu.edu.cn> Reviewed-by: Atish Patra <atish.patra@wdc.com> --- include/sbi/sbi_fifo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'include') diff --git a/include/sbi/sbi_fifo.h b/include/sbi/sbi_fifo.h index bc8f8f6..1a85f07 100644 --- a/include/sbi/sbi_fifo.h +++ b/include/sbi/sbi_fifo.h @@ -33,8 +33,8 @@ int sbi_fifo_dequeue(struct sbi_fifo *fifo, void *data); int sbi_fifo_enqueue(struct sbi_fifo *fifo, void *data); void sbi_fifo_init(struct sbi_fifo *fifo, void *queue_mem, u16 entries, u16 entry_size); -bool sbi_fifo_is_empty(struct sbi_fifo *fifo); -bool sbi_fifo_is_full(struct sbi_fifo *fifo); +int sbi_fifo_is_empty(struct sbi_fifo *fifo); +int sbi_fifo_is_full(struct sbi_fifo *fifo); int sbi_fifo_inplace_update(struct sbi_fifo *fifo, void *in, int (*fptr)(void *in, void *data)); u16 sbi_fifo_avail(struct sbi_fifo *fifo); -- cgit v1.2.3